fix: address security review findings, implement real cache clearing, and fix lifecycle promises

bot/lib/BotClient.test.ts

@@ -38,6 +38,15 @@ mock.module("../lib/loaders/EventLoader", () => ({
 }));
 
 // Mock dashboard service to prevent network/db calls during event handling
+mock.module("@shared/modules/economy/lootdrop.service", () => ({
+    lootdropService: { clearCaches: mock(async () => { }) }
+}));
+mock.module("@shared/modules/trade/trade.service", () => ({
+    tradeService: { clearSessions: mock(() => { }) }
+}));
+mock.module("@/modules/admin/item_wizard", () => ({
+    clearDraftSessions: mock(() => { })
+}));
 mock.module("@shared/modules/dashboard/dashboard.service", () => ({
     dashboardService: {
         recordEvent: mock(() => Promise.resolve())
@@ -48,11 +57,12 @@ describe("AuroraClient System Events", () => {
     let AuroraClient: any;
 
     beforeEach(async () => {
-        // Clear mocks and re-import client to ensure fresh listeners if possible
-        // Note: AuroraClient is a singleton, so we mostly reset its state
+        systemEvents.removeAllListeners();
         const module = await import("./BotClient");
         AuroraClient = module.AuroraClient;
         AuroraClient.maintenanceMode = false;
+        // MUST call explicitly now
+        await AuroraClient.setupSystemEvents();
     });
 
     /**
@@ -61,14 +71,11 @@ describe("AuroraClient System Events", () => {
      */
     test("should toggle maintenanceMode when MAINTENANCE_MODE event is received", async () => {
         systemEvents.emit(EVENTS.ACTIONS.MAINTENANCE_MODE, { enabled: true, reason: "Testing" });
-
-        // Give event loop time to process
-        await new Promise(resolve => setTimeout(resolve, 20));
-
+        await new Promise(resolve => setTimeout(resolve, 30));
         expect(AuroraClient.maintenanceMode).toBe(true);
 
         systemEvents.emit(EVENTS.ACTIONS.MAINTENANCE_MODE, { enabled: false });
-        await new Promise(resolve => setTimeout(resolve, 20));
+        await new Promise(resolve => setTimeout(resolve, 30));
         expect(AuroraClient.maintenanceMode).toBe(false);
     });
 
@@ -77,16 +84,28 @@ describe("AuroraClient System Events", () => {
      * Requirement: loadCommands and deployCommands should be called
      */
     test("should reload commands when RELOAD_COMMANDS event is received", async () => {
-        // Spy on the methods that should be called
         const loadSpy = spyOn(AuroraClient, "loadCommands").mockImplementation(() => Promise.resolve());
         const deploySpy = spyOn(AuroraClient, "deployCommands").mockImplementation(() => Promise.resolve());
 
         systemEvents.emit(EVENTS.ACTIONS.RELOAD_COMMANDS);
-
-        // Wait for async handlers
         await new Promise(resolve => setTimeout(resolve, 50));
 
         expect(loadSpy).toHaveBeenCalled();
         expect(deploySpy).toHaveBeenCalled();
     });
+
+    /**
+     * Test Case: Cache Clearance
+     * Requirement: Service clear methods should be triggered
+     */
+    test("should trigger service cache clearance when CLEAR_CACHE is received", async () => {
+        const { lootdropService } = await import("@shared/modules/economy/lootdrop.service");
+        const { tradeService } = await import("@shared/modules/trade/trade.service");
+
+        systemEvents.emit(EVENTS.ACTIONS.CLEAR_CACHE);
+        await new Promise(resolve => setTimeout(resolve, 50));
+
+        expect(lootdropService.clearCaches).toHaveBeenCalled();
+        expect(tradeService.clearSessions).toHaveBeenCalled();
+    });
 });