test: refactor mocks to use spyOn for better isolation

src/modules/economy/lootdrop.service.test.ts

@@ -1,7 +1,8 @@
-import { describe, it, expect, mock, beforeEach, afterEach } from "bun:test";
+import { describe, it, expect, mock, beforeEach, afterEach, spyOn } from "bun:test";
 import { lootdropService } from "./lootdrop.service";
 import { lootdrops } from "@/db/schema";
 import { eq, and, isNull } from "drizzle-orm";
+import { economyService } from "./economy.service";
 
 // Mock dependencies BEFORE using service functionality
 const mockInsert = mock();
@@ -34,16 +35,6 @@ mock.module("@/lib/DrizzleClient", () => {
     };
 });
 
-// Mock EconomyService
-const mockModifyUserBalance = mock();
-mock.module("./economy.service", () => {
-    return {
-        economyService: {
-            modifyUserBalance: mockModifyUserBalance
-        }
-    };
-});
-
 // Mock Config
 mock.module("@/lib/config", () => ({
     config: {
@@ -63,6 +54,7 @@ mock.module("@/lib/config", () => ({
 
 describe("lootdropService", () => {
     let originalRandom: any;
+    let mockModifyUserBalance: any;
 
     beforeEach(() => {
         mockInsert.mockClear();
@@ -74,7 +66,6 @@ describe("lootdropService", () => {
         mockWhere.mockClear();
         mockSelect.mockClear();
         mockFrom.mockClear();
-        mockModifyUserBalance.mockClear();
 
         // Reset internal state
         (lootdropService as any).channelActivity = new Map();
@@ -82,10 +73,14 @@ describe("lootdropService", () => {
 
         // Mock Math.random
         originalRandom = Math.random;
+
+        // Spy
+        mockModifyUserBalance = spyOn(economyService, 'modifyUserBalance').mockResolvedValue({} as any);
     });
 
     afterEach(() => {
         Math.random = originalRandom;
+        mockModifyUserBalance.mockRestore();
     });
 
     describe("processMessage", () => {