feat: Add user existence checks to economy commands and refactor trade service to expose sessions for testing.

src/commands/economy/balance.ts

@@ -23,6 +23,8 @@ export const balance = createCommand({
 
         const user = await userService.getOrCreateUser(targetUser.id, targetUser.username);
 
+        if (!user) throw new Error("Failed to retrieve user data.");
+
         const embed = createBaseEmbed(undefined, `**Balance**: ${user.balance || 0n} AU`, "Yellow")
             .setAuthor({ name: targetUser.username, iconURL: targetUser.displayAvatarURL() });
 

src/commands/economy/exam.ts

@@ -25,6 +25,10 @@ export const exam = createCommand({
     execute: async (interaction) => {
         await interaction.deferReply();
         const user = await userService.getOrCreateUser(interaction.user.id, interaction.user.username);
+        if (!user) {
+            await interaction.editReply({ embeds: [createErrorEmbed("Failed to retrieve user data.")] });
+            return;
+        }
         const now = new Date();
         const currentDay = now.getDay();
 
@@ -47,7 +51,7 @@ export const exam = createCommand({
 
                 const metadata: ExamMetadata = {
                     examDay: currentDay,
-                    lastXp: user.xp.toString()
+                    lastXp: (user.xp ?? 0n).toString()
                 };
 
                 await DrizzleClient.insert(userTimers).values({
@@ -98,7 +102,7 @@ export const exam = createCommand({
 
                 const newMetadata: ExamMetadata = {
                     examDay: examDay,
-                    lastXp: user.xp.toString() // Reset tracking
+                    lastXp: (user.xp ?? 0n).toString()
                 };
 
                 await DrizzleClient.update(userTimers)
@@ -125,7 +129,7 @@ export const exam = createCommand({
 
             // 5. Reward Calculation
             const lastXp = BigInt(metadata.lastXp || "0"); // Fallback just in case
-            const currentXp = user.xp;
+            const currentXp = user.xp ?? 0n;
             const diff = currentXp - lastXp;
 
             // Calculate Reward

src/commands/economy/pay.ts

@@ -33,6 +33,11 @@ export const pay = createCommand({
 
         const amount = BigInt(interaction.options.getInteger("amount", true));
         const senderId = interaction.user.id;
+        if (!targetUser) {
+            await interaction.reply({ embeds: [createErrorEmbed("User not found.")], flags: MessageFlags.Ephemeral });
+            return;
+        }
+
         const receiverId = targetUser.id;
 
         if (amount < config.economy.transfers.minAmount) {
@@ -40,14 +45,14 @@ export const pay = createCommand({
             return;
         }
 
-        if (senderId === receiverId) {
+        if (senderId === receiverId.toString()) {
             await interaction.reply({ embeds: [createErrorEmbed("You cannot pay yourself.")], flags: MessageFlags.Ephemeral });
             return;
         }
 
         try {
             await interaction.deferReply();
-            await economyService.transfer(senderId, receiverId, amount);
+            await economyService.transfer(senderId, receiverId.toString(), amount);
 
             const embed = createSuccessEmbed(`Successfully sent ** ${amount}** Astral Units to <@${targetUser.id}>.`, "💸 Transfer Successful");
             await interaction.editReply({ embeds: [embed], content: `<@${receiverId}>` });