syntaxbullet/aurorabot
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: standardize error classes in shared service modules

Browse Source 
Replace raw `Error` with `UserError` for user-facing conditions (invalid trade state, user not found, permission/channel type checks) and `SystemError` for internal failures (DB insert failures, external API errors, missing config). Improves Discord UX by ensuring user-facing errors are surfaced cleanly via withCommandErrorHandling.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
syntaxbullet
2026-03-18 12:51:16 +01:00
parent 22e446ff28
commit a96c6caa49
8 changed files with 32 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shared/modules/moderation/moderation.service.ts
View File

@@ -4,6 +4,7 @@ import { DrizzleClient } from "@shared/db/DrizzleClient";
import type { CreateCaseOptions, ClearCaseOptions, SearchCasesFilter } from "@/modules/moderation/moderation.types";
import { getUserWarningEmbed } from "@/modules/moderation/moderation.view";
import { CaseType } from "@shared/lib/constants";
import { SystemError } from "@shared/lib/errors";
export interface ModerationCaseConfig {
dmOnWarn?: boolean;
@@ -100,7 +101,7 @@ export const moderationService = {
});
if (!moderationCase) {
throw new Error("Failed to create moderation case");
throw new SystemError("Failed to create moderation case");
}
const warningCount = await getActiveWarningCount(options.userId);